PvXwiki:Curse noticeboard

From PvXwiki
Jump to: navigation, search

The Curse Noticeboard

This is a place where issues that only a Curse Staff member can sort out. These issues will usually pertain to coding problems, relating to our PvXCode, or even the wiki's numerous extensions and special pages.

Please remember that PvXWiki has it's own Admin Noticeboard, and if an issue can be solved by an admin, post the issue there and not here.

To post an issues, please add it to the bottom of the section which the issue belongs, give the issue a suitable heading (Using a level 3 heading (3 ='s either side of the heading) E.G. ===Special:RecentRatings=== if there's a problem with the Recent Ratings page). Underneath the heading, give a brief discription of what's wrong, and sign and date your issue with 4 ~'s.

Note that this is not a talk page and that the respective moderators of each section reserve the right to remove non-administrative comments without discussion.

User Rights issues

This section is for issues related to user rights. Archived issues for this section can be found here.

General issues



These issues are generally related to the Mediawiki software, and any extensions that are installed (please note that PvX Extensions for guild wars tooltips etc. have their own section below).

PvX Extension issues



Coding issues related to PvXCode and PvXRate. For any skills with incorrect descriptions or images, add a new heading and give an example within pvxbig tags using [skill name]. Add a description of the problem under the PvXbig tags. Any issues that have fixes drafted and awaiting sync will be noted.

Occasionally tooltips don't display on page load

Kinda hard to debug this one, but sometimes the skill tooltips with "hovertooltip" class don't show the tooltips when hovering. Examination of the browser console suggests that the pvxcode.js code is loading, so I assume this is a timing issue, probably where the javascript finishes loading before the page content (i.e. it applies the tooltip code to the page, finds no elements to add the script to, then the page adds the tooltip nodes, which is too late). Probably replace the with last line on overlib.js with the following

document.addEventListener("DOMContentLoaded", function(event) { 

-Chieftain Alex (talk) 10:57, 12 April 2020 (UTC)

Probably worth noting this seems to occur on firefox way more often than any of the other browsers. -Chieftain Alex (talk) 16:47, 20 June 2020 (UTC)

Rating tab

The rating tab added by Extension:PvXRate (which I've hidden sidewide using CSS, has id #ca-rate) links to the first portion of a build pagename, and for some reason drops anything after slashes (e.g. for "Build:E/Any Stoning" it would link to "?title=Build:E&action=rate". Source seems to be line 112 of PvXRate.hooks.php. Not sure which function I need to replace it with from mw:Manual:Title.php. For the time being I've left the original tab added by the javascript Mediawiki:Hydra.js page (id #special-rate), so there's no functionality change compared with previous. -Chieftain Alex (talk) 20:12, 21 April 2020 (UTC)

Removed Ratings Display

Four votes have been removed here according to Recent Ratings, but I could only see my removed rating until I permanently deleted mine. -Toraen (talk) 13:50, 1 May 2020 (UTC)

As in, only the removed rating showed + there was a box to resubmit it, but none of the other votes appeared on the page for you at all? -Chieftain Alex (talk) 21:28, 1 May 2020 (UTC)
I think that I found the cause. I suspect line 362 of RateAction.php should be using .= - currently it's just using = which will overwrite the additions from the previous loop... this probably means the number of rolledback+displayed votes depends entirely on the order we rollback the votes. -Chieftain Alex (talk) 22:24, 1 May 2020 (UTC)

Voting pages as anon with removed votes

Viewing voting pages when anon doesn't separate removed votes from the valid votes. example link screenshot -Chieftain Alex (talk) 17:52, 20 June 2020 (UTC)

Vote comments with headings

If a voting comment uses wikicode such as "=== heading ===" more than 3x, then a table of contents is created. Additionally a section edit button is "almost" generated, it renders as <mw:sectionedit>section title</mw:sectionedit>. -Chieftain Alex (talk) 17:56, 20 June 2020 (UTC)

Would adding the noeditsection and notoc magic words to the special page fix that? I feel like it should if it's interpreting wikicode already. -Toraen (talk) 20:15, 2 July 2020 (UTC)

Strength and attacks with armor penetration

PvXbig will add a Strength tooltip to these skills even though its effect does not stack with those skills' inherent penetration. Could probably write an exception in for those skills easily enough. -Toraen (talk) 13:57, 23 May 2020 (UTC)

Added add_strength function to line 1162 and line 1231 to handle the above cases. --Chieftain Alex (talk) 16:36, 20 June 2020 (UTC)
I've copied it to mine, though I will note that technically the bow attacks' penetration can be replaced by Strength's if the latter is higher (I don't think anyone's going to submit a Hambow build anytime soon though so I don't actually care). -Toraen (talk) 10:37, 21 June 2020 (UTC)
Changes live. Maybe someday will fix the ranger skills. -Toraen (talk) 13:54, 25 June 2020 (UTC)
I think I've got it. Requesting check for dumb errors. -Toraen (talk) 23:55, 30 June 2020 (UTC)
Looks good (took me a minute to realise the negation on the preg_match had gone). I did wonder if we need to convert the match into a number, but it seems we did similar stuff all over the gwbbcode.inc.php file anyway. -Chieftain Alex (talk) 15:39, 1 July 2020 (UTC)
Pushed into the merge request. -Toraen (talk) 19:14, 1 July 2020 (UTC)

12 + 1 + 3
Your attack skills gain 16% armor penetration.
Template code

Skill Wearying Strike is not from one of the build professions

So looks like I messed this one up. -Toraen (talk) 17:01, 13 September 2020 (UTC)

Oof. Surprised it broke tbh, looked ok but i guess double arrow notation immediately assigns the strength value, then overwrites with the % sign.
Probably would work: 'value' => ($sacrifice . '%') or 'value' => "$sacrifice%")
-Chieftain Alex (talk) 20:42, 14 September 2020 (UTC)

Fatal exception when trying to vote

[214095b065b92f44] 2020-09-27 12:05:56: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

The page I was attempting to rate was Build:N/Mo 55hp Boss Farmer. I successfully navigated to the rating page, and I've confirmed my email this morning. I forget what the user requirements are in order to be able to vote, but the page appeared to present the correct form, but sent an error after trying to submit the rating. -Chieftainalex (talk) 12:08, 27 September 2020 (UTC)

Same on Build:D/Mo RA Empathic Removal: [6e07f0b8f9541ecc] 2020-09-27 13:46:20: Fatal exception of type "Wikimedia\Rdbms\DBQueryError" Toraen (talk) 13:50, 27 September 2020 (UTC)
Almost a month has passed by and this error still occurs :'( Jorre22225G (talk) 21:36, 18 October 2020 (UTC)
Gave one of our Curse contacts a second poke on this over email (last prodded 1st October), see if it gets their attention. --Chieftain Alex (talk) 23:35, 18 October 2020 (UTC)
Also, for the record, you can modify existing votes but you cannot submit new ones. --Chieftain Alex (talk) 23:36, 18 October 2020 (UTC)
Just to demonstrate we're getting some responsesd from Gamepedia:
19/10/2020 12:20
I will have that escalated, I apologise for not checking back with you
19/10/2020 18:23
The platform team is actively looking into this issue as I type.
23/10/2020 20:13
I just wanted to update you on the status of the ticket for you wiki. There is a partial fix in place although more work needs to be done and a more complete fix is coming for the errors being thrown by PvXRate.
--Chieftain Alex (talk) 09:05, 24 October 2020 (UTC)
Also for the record, I sometimes get the same error when moving a page that has ratings attached to it, e.g. with Archive:Team - 7 Hero BiP Melee Support [45e96285b4ac2b12] 2020-10-24 09:01:24: Fatal exception of type "Wikimedia\Rdbms\DBQueryError" on Special:MovePage after it completed otherwise successfully. --Chieftain Alex (talk) 09:07, 24 October 2020 (UTC)
I am getting the same error as well. Just tried voting on Build:Rt/any_Duncan The Black Solo Hero and got the error. MozoGW (talk) 16:35, 25 October 2020 (UTC)
Yup it affects everyone for applying new votes. Hence why we've had no new votes since September 20th (18th October was me modifying an existing vote). --Chieftain Alex (talk) 17:09, 25 October 2020 (UTC)
Curse have pushed some updates today, and they thought it might be fixed, but unfortunately my test threw the same error as before. --Chieftain Alex (talk) 18:44, 29 October 2020 (UTC)
Received notification today that the bug is fixed... which I've confirmed by successfully rating something. --Chieftain Alex (talk) 17:04, 30 October 2020 (UTC)