ATTENTION: If you have an account that was recently deleted and are located in the European Economic Area (EEA), please see this announcement.

Hi Gamepedia users and contributors! Please complete this survey to help us learn how to better meet your needs in the future. We have one for editors and readers. This should only take about 7 minutes!

PvXwiki:Curse noticeboard

From PvXwiki
Jump to: navigation, search

The Curse Noticeboard

This is a place where issues that only a Curse Staff member can sort out. These issues will usually pertain to coding problems, relating to our PvXCode, or even the wiki's numerous extensions and special pages.

Please remember that PvXWiki has it's own Admin Noticeboard, and if an issue can be solved by an admin, post the issue there and not here.

To post an issues, please add it to the bottom of the section which the issue belongs, give the issue a suitable heading (Using a level 3 heading (3 ='s either side of the heading) E.G. ===Special:RecentRatings=== if there's a problem with the Recent Ratings page). Underneath the heading, give a brief discription of what's wrong, and sign and date your issue with 4 ~'s.

Note that this is not a talk page and that the respective moderators of each section reserve the right to remove non-administrative comments without discussion.

User Rights issues

This section is for issues related to user rights. Archived issues for this section can be found here.

General Coding issues

These issues are generally related to the Mediawiki software, and any extensions that are installed (please note that PvXCode has it's own section below). See here for archived issues.

Rate Extension Reason Box

The section of a vote reserved for the reasoning appears to now have a fixed height, which causes problems with votes where the author decided to provide a bit more elaboration than usual. See some examples here. -Toraen (talk) 11:28, 30 November 2018 (UTC)

Ticket is in to dev for this now. OOeyes (talk) 18:05, 1 December 2018 (UTC)

PvXcode issues

Coding issues related to PvXcode. See also PvXwiki talk:PvXcode. See here for archived PvXCode issues.

Energy Exhaustion Overcast Costs

These do not show up at all in the mouseovers of skills.

Some examples:


Health Sacrifice Costs

These do not show up at all in the mouseovers of skills. ToraenTheJanitorToraenSig2.png 14:15, 11 September 2010 (UTC)

Some examples:


Found the following on PvXwiki talk:PvXcode: In function skill_replace add

if ($sacrifice != 0)
         $required[] = infuse_values($gwbbcode_tpl['requirement'], Array('type' => 'sacrifice', 'value' => $sacrifice));

-- Toraen talk 00:04, 5 October 2011 (UTC)

huh? didn't i add that already? I was sure i did it at the same time as...something. ~ PheNaxKian talk 17:03, 5 October 2011 (UTC)
Nope, there's no mention of sacrifice in the copy I currently have uploaded to the box (and that one's ahead of what we've got live). -- Toraen talk 20:08, 5 October 2011 (UTC)

Primary Attributes

  • Spawning Power's effect on weapon spell duration was increased from +2% per rank to +4% per rank. Now live.
  • Fast Casting has had a significant rework, and is split between PvP and PvE. Mesmer spells will need to show recharge reduction based on the attribute for PvE.
  • Leadership shows a modification to the cost of shouts, and this needs to be removed. Leadership merely returns energy, it does not change the cost. Leadership's effect on Shouts and Chants will need to display as "This shout/chant grants X Energy for each affected earshot ally" (similar to "This attack skill has X% armor penetration" displayed by Strength).
  • Mysticism has been completely reworked, and is split between PvP and PvE. Dervish enchantments will need to show cost reduction based on the attribute.

ToraenTheJanitorToraenSig2.png 14:15, 11 September 2010 (UTC)

(PvP) Skills and Template Codes

When (PvP) skills are added to a build template, they generate an invalid code. There has been much discussion on possible solutions here and other places. ToraenTheJanitorToraenSig2.png 14:15, 11 September 2010 (UTC)

I thought this was largely worked out or a fix had been found? Also, there aren't pictures for the PvP skills. —ǥrɩɳsɧƴɖɩđđɭɘş Grinshpon blinky cake.gif 05:59, 23 November 2010 (UTC)
Not fixed at all while we were at wikia. Solutions were provided, but not tested/implemented. Wikia just seemed to completely lose interest after a while. --Toraen 06:02, 23 November 2010 (UTC)
We will implement it, but i'm letting Bryan sort out GWiki first and probably tinker with the extension at the same time on their staging server (when it's set up). So the solution's ready, but It'll be a bit longer --Phen 152.105.20.42

This should now be fixed! ~ PheNaxKian talk 16:37, 11 August 2011 (UTC)

Just noting here that there seems to be a problem with the ID conversion, as noted in many other places. -- Toraen talk 01:14, 15 August 2011 (UTC)

PvE Skills

Ebon Escape

PvE skills don't show the scaled amounts at specific ranks. e.g. if I type @10 after the pvxbig code, it still shows how the numbers scale from r1-10--Chieftain Alex 15:09, 26 January 2011 (UTC)

Linking

Skills in pvxbig formatted as [[Skill] do not link to the gww page for the skill. See the skill in the above section. ToraenTheJanitorToraenSig2.png 20:14, 26 January 2011 (UTC)

This was raised a while ago (I think by me). Apparently it's not a bug, but the way the extension works means that we couldn't have it link (or it'd be hard, or something....I'll see if I can find it). ~ PheNaxKian talk 22:07, 26 January 2011 (UTC)
it's been brought up a couple of times but never been answered. Don't know what I was thinking of <<. ~ PheNaxKian talk 22:19, 26 January 2011 (UTC)

PvX Decode

Puts pvp skills if possible into template. Unhelpful since they don't work, maybe revert to an old version before pvp skills? Chieftain Alex 00:14, 13 March 2012 (UTC)

Also, the title of the page when you go to it is now <pvxdecode> due to the mediawiki upgrade. -- Toraen confer 16:23, 14 March 2012 (UTC)

More issues: attempting to display from a template code that has a multi-word named skill in it can cause it to be replaced with a PvP skill that shares the first word of the skill name. The original report is here. -- Toraen confer 20:11, 11 July 2012 (UTC)

PvXbig Skill Errors

Add any skills with incorrect descriptions or images to the list inside the PvXbig tags using [skill name]. Add a description of the problem under the PvXbig tags. Issues fixed in the editcopy and awaiting sync will be noted. Once the sync has taken place, all fixed skills will be removed from the list.

 Aneurysm-Aneurysm-Aneurysm-Aneurysm


New Issues

  • Wrong scaling of aneurysm. An unspecified [[Aneurysm] spits out correct values. Once specifying an attribute value, the maximum energy loss snaps to 10/20/30/40 instead of scaling correctly. It seems to simply pick damage/energy times 10 as the value instead of 1...24...30.
I cannot for the life of me figure out why this skill and only this skill is doing that. It appears to be formatted correctly in the database:
'desc'=>'Target foe regains all Energy. For each point of Energy gained in this way, that foe takes 1..3 damage and all adjacent foes lose 1 Energy. (Maximum 1..30).'
and I can't find any special code related to aneurysm in any of the other files. I'll try looking again after I've had some sleep. -Toraen (talk) 09:29, 24 November 2019 (UTC)
I think I've isolated the problem, the gws_adapt_description function is seeing what I've highlighted in red on its first pass for scaling value replacement (to replace the first value) and since there are two matches in the description it replaces both with the same value. Then it has no matches for the second scaling value because it already replaced part of it (leaving just the 0 tacked on to the end of where it dropped the second instance of the first value). I'll try to code a fix for this later but if anyone else reading wants to give it a go, line 1368 of this is where that function starts. -Toraen (talk) 12:53, 24 November 2019 (UTC)
My PHP isn't great, but at a quick glance looks like the issue is line 1409. When you're setting the scaling text, it uses the value for when the relevant attribute is set to 16, not 15. This would affect all skills (provided they have a different value when at 15 and 16), which you can see by checking the skills further up the page (e.g. blood pact). ~ PheNaxKian talk 23:06, 24 November 2019 (UTC)
That's not quite the issue with aneurysm, and 16 was set as our upper value on ranges intentionally iirc, since 16 (max points+headpiece+superior) makes more sense to display for build optimization than 15 (max points+superior). Aneurysm is displaying the wrong value for its second scaling number, but the correct one for the first scaling number, when an attribute is specified. -Toraen (talk) 06:59, 25 November 2019 (UTC)
I'm dumb and can't read. Also as you said, the replace is hitting both ranges in the description on when replacing the first one. Replace line 1368 with this:
$pos = strpos($desc, $all);
$desc = substr_replace($desc, fork_val($val_0, $val_15, $attr_lvl), $pos, strlen($all));
Have Curse check it over, but that gets the position of the string we're interested in (e.g. 1..3) and then replaces that with the correct value (e.g. 3) ~ PheNaxKian talk 20:24, 25 November 2019 (UTC)
1386 surely. (no idea about php but 1368 ain't the right line..)
also I guess that !$pve_only branch is the reason why I've got a 2011 Ebon Escape bug report above. -Chieftain Alex (talk) 00:10, 4 December 2019 (UTC)
Yeah, that blank branch is why. Should be trivial to put the scaling in actually (if you're not me). By the way, that is a Gitlab repository linked (and it has the full pvxcode and pvxrate extensions on it, behold them and despair), so technically anyone can make a pull request for a code change (it being accepted is obviously contingent on your code actually working). -Toraen (talk) 13:18, 4 December 2019 (UTC)