PvXwiki talk:Extension Development

Slight divergence, the current merge request is from User:Amorality's fork as that merge request was submitted before I wrote this up. Once gamepedia merges it we'll go back to using Alex's fork. -Toraen (talk) 15:18, 24 April 2020 (UTC)

If we want to use someone else's fork as the permanent dev version feel free, I don't even know how to resync with the original. I've invited Amorality anyway. -Chieftain Alex (talk) 17:57, 24 April 2020 (UTC)

This was my first time contributing, I just wanted to add something quick and easy and have just been embroiled into something above my skill level. I don't mind doing the basics such as data entry and the like. Amorality (talk) 20:14, 24 April 2020 (UTC)

I merged the stuff from our forks to yours, I think that'll catch you up and prevent future conflicts. Otherwise: https://xkcd.com/1597/. -Toraen (talk) 01:43, 26 April 2020 (UTC)

I've pushed two more commits to my fork this morning; #1 ensures bullets on newlines after build tags work ok (will create a bug on curse noticeboard in a minute), and #2 is a minor CSS improvement (no duplicate id elements on the same page which is imo bad practice). -Chieftain Alex (talk) 09:49, 26 April 2020 (UTC)

Feature ideas

Just slapping some ideas down on the page.

PvXRate

• Easy: Make the PvX special pages following the uppercase first only convention used on every other page (e.g. "Recent Ratings" would become "Recent ratings")
• Easy: Would be nice not to have to refresh the page to show your rating after submitting it. Might be possible to bind a reload page event after the rating has successfully been submitted.
• Easy: Display how many results are shown on Special:RecentRatings (answer is 200).
• Easy: Mediawiki message page option to customise the text at the top of pages such as Special:UserRatings and Special:RecentRatings. Should be able to check the source of Special:RecentChanges and replicate that. Could then link between the PvXRate special pages.
• Medium: Provide a box on Special:UserRatings to enter a user's name to link to the existing Special:UserRatings/<username>.
• Hard: Store the overall rating of a page in a separate SQL table. The new SQL table would need the page's value updating every time a vote is added or removed. Would need: (1) Overall score, and (2) Number of ratings.
  • This would probably be the easiest way to unlock the ability to add parser functions to retrieve a build's rating... e.g. {{#ratingscore:PAGENAME}} ==> 4.75 & {{#ratingcount:PAGENAME}} ==> 6 which would mean we could then put the rating directly into the build-vetting template.
• Hard: MW API action module to retrieve individual votes from the database. Not sure why this would be useful.
• Hard: Bcrat/Admin-only bulk functions: merging ratings from one user to another, vote wipes, deleting orphaned ratings, etc.
• Hard: Wiki-side configurations page (probably bcrat accessible only): names/hover descriptions/weight of criteria, thresholds for ratings

-Chieftain Alex (talk) 17:18, 26 April 2020 (UTC)

PvXCode

• Easy: Could delete Special:PvXConvert - it's ancient and provides a migration feature from the original GuildWiki template that probably has not been used in years (which would explain why I found so many errors within it when I revamped it).
• Medium: Might be nice to add the mini skill bar equivalent to PvXDecode, such that you put the ingame build IN, and get both the [build][/build] and {{mini skill bar}} formats OUT (but in separate boxes).
• Medium: Allow arbitrary bonuses in the base template (to support cons or other effects) without rendering the build invalid (no code generated).

-Chieftain Alex (talk) 17:18, 26 April 2020 (UTC)

• PvXConvert: User:Vegetaledefender has made a convert tool that would be a great replacement. I'm not sure it's 100% finished, but I've already used it for a couple of pages.
• Adrenaline costs: Some skills have incorrect ingame adrenaline costs. Would it be possible to display the actual cost?

--Krschkr (talk) 21:37, 26 April 2020 (UTC)

Displaying various errata for skills would probably be pretty helpful, given how unhelpful some in-game skill descriptions are. Probably implement it as another variable in the skill_db array which is then displayed after the description? Showing bugs will need to be rather free-form. -Toraen (talk) 19:08, 28 April 2020 (UTC)

4/30 Update

Don't know if Anet is going to do any other quick fixes, so it's just a branch of Alex's fork right now. -Toraen (talk) 00:47, 1 May 2020 (UTC)

Lol typical balance patch as soon as PvX is synced. -Chieftain Alex (talk) 07:33, 1 May 2020 (UTC)

If we just synced it more often maybe we'd have had more frequent balance patches. -Toraen (talk) 15:22, 1 May 2020 (UTC)

MW 1.34 & MW 1.35

Gamepedia haven't updated pvx yet, but when MW 1.34 hits there will be a few tweaks to make, such as:

• wfGetDB(DB_SLAVE); will be replaced with wfGetDB(DB_REPLICA); — For PvXRate
• $wgOut->addWikiText(...) will be replaced with $wgOut->addWikiTextAsContent(...) — For PvXRate

-Chieftain Alex (talk) 17:40, 20 June 2020 (UTC)

There's a block of code on pvxrate rateAction.php and I don't know how to migrate it.

		$parserOptions = ParserOptions::newFromUser($wgUser);
		$parserOptions->setEditSection(false);
		$parserOptions->setTidy(true);
		$wgParser->mShowToc = false;

setTidy is always enabled so that line does nothing and can be deleted.

I can't find the working syntax to make the TOC not appear + the editsection buttons to not appear. From the migration notes it's got to be added to the "options" array but idk how to do that. -Chieftain Alex (talk) 18:49, 20 June 2020 (UTC)

I'd quite like to get on with implementing the revised rating limits, but not being able to preview the extension changes on my test server is annoying. -Chieftain Alex (talk) 18:50, 20 June 2020 (UTC)

Recent Ratings

Special:RecentRatings currently displays a blank page. --Krschkr (talk) 19:33, 23 September 2020 (UTC)

Ugh. It's not even the MW 1.34/1.35 patch which I know will break the extensions pretty hard. -Chieftainalex (talk) 20:37, 23 September 2020 (UTC)

Special:UserRatings also affected. I'm wondering if the SQL rating tables got dumped somehow? -Chieftainalex (talk) 20:42, 23 September 2020 (UTC)

Also all my preferences, signature, edit count (I'm at 2!).... wtf? -Chieftainalex (talk) 20:44, 23 September 2020 (UTC)

I had only noticed a partial preferences reset so far. Let's see how many quirks will be left after the hotfix tomorrow. --Krschkr (talk) 20:54, 23 September 2020 (UTC)

It actually feels like the extensions have been reset to a previous version that's missing a couple of bug-fixes and the new anniversary skills. --Krschkr (talk) 22:15, 23 September 2020 (UTC)

I've filed a ticket for the ratings issues and the old version. I also noted in the tickets that the rate option on the build pages isn't functioning (at least for me). SBEyes (talk) 23:08, 23 September 2020 (UTC)

Yes, somehow older versions of the extensions were being used. They've been updated, and things now seem to be functioning correctly on my spot check. Can you double check and confirm these issues have been resolved? SBEyes (talk) 20:27, 24 September 2020 (UTC)

I'm seeing some misaligned sections on build displays (the attribute numbers and the download button in particular) and missing hex/enchantment/assassin chain overlays:

Browser is Firefox 81. Toraen (talk) 00:09, 25 September 2020 (UTC)